[webkit-reviews] review granted: [Bug 191808] Rename RenderLayerCompositor::inCompositingMode() to usesCompositing() : [Attachment 355196] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 191808: Rename RenderLayerCompositor::inCompositingMode() to
usesCompositing()
https://bugs.webkit.org/show_bug.cgi?id=191808

Attachment 355196: Patch

https://bugs.webkit.org/attachment.cgi?id=355196&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 355196
  --> https://bugs.webkit.org/attachment.cgi?id=355196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355196&action=review

> Source/WebCore/page/FrameView.cpp:2412
>	   clearBackingStores();

I'd go even one step further and move clearBackingStore() into a lambda since
no one else calls into it (it's public on FrameView!) and then you could even
drop some lines from clearBackingStores (assert and the renderView() check)