[webkit-reviews] review granted: [Bug 191800] Regression(ProcessPrewarming) Assertion hit in NetworkProcessProxy destructor : [Attachment 355178] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 191800: Regression(ProcessPrewarming) Assertion hit in NetworkProcessProxy
destructor
https://bugs.webkit.org/show_bug.cgi?id=191800

Attachment 355178: Patch

https://bugs.webkit.org/attachment.cgi?id=355178&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 355178
  --> https://bugs.webkit.org/attachment.cgi?id=355178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355178&action=review

> Source/WebKit/ChangeLog:9
> +	   Make sure the NetworkProcessProxy destructor calls its remaining
m_pendingConnectionReplies
> +	   completion handlers to avoid hitting an assertion in the
CompletionHandler destructor.

I guess this is a regression from https://trac.webkit.org/changeset/238335 ?