[webkit-reviews] review granted: [Bug 191785] Web Inspector: Include default filtering of InspectorBackend.dumpInspectorProtocolMessages with multi target backend : [Attachment 355146] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 191785: Web Inspector: Include default filtering of
InspectorBackend.dumpInspectorProtocolMessages with multi target backend
https://bugs.webkit.org/show_bug.cgi?id=191785

Attachment 355146: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=355146&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 355146
  --> https://bugs.webkit.org/attachment.cgi?id=355146
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=355146&action=review

r=me

> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js:45
> +    const dumpMessagesToolTip = WI.unlocalizedString("Enable dump inspector
messages to console.\nShift-click to dump inspector all messages with no
filtering.");

"inspector all messages" -> "all inspector messages"

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:109
> +    }

Style: we usually put the getter above the setter for read/write properties.

> Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js:68
> +    }

Ditto.