[webkit-reviews] review granted: [Bug 191740] Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Local Inspector) : [Attachment 355124] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 191740: Web Inspector: Keep Web Inspector window alive across process swaps
(PSON) (Local Inspector)
https://bugs.webkit.org/show_bug.cgi?id=191740

Attachment 355124: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=355124&action=review




--- Comment #7 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 355124
  --> https://bugs.webkit.org/attachment.cgi?id=355124
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=355124&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp:95
> -    return m_page->inspector();
> +    return nullptr;

Why does this always return nullptr now? Change to void?