[webkit-reviews] review granted: [Bug 191771] All users of ArrayBuffer should agree on the same max size : [Attachment 355121] the patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 191771: All users of ArrayBuffer should agree on the same max size
https://bugs.webkit.org/show_bug.cgi?id=191771

Attachment 355121: the patch

https://bugs.webkit.org/attachment.cgi?id=355121&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 355121
  --> https://bugs.webkit.org/attachment.cgi?id=355121
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355121&action=review

r=me

> Source/JavaScriptCore/runtime/ArrayBuffer.cpp:119
> +    RELEASE_ASSERT(m_sizeInBytes <= MAX_ARRAY_BUFFER_SIZE);

nit: This can be a debug ASSERT because we already have a size check above to
ensure this.