[webkit-reviews] review granted: [Bug 191766] Web Inspector: TreeOutline shouldn't select first child of an expanded element on right arrow key : [Attachment 355104] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 191766: Web Inspector: TreeOutline shouldn't select first child of an
expanded element on right arrow key
https://bugs.webkit.org/show_bug.cgi?id=191766

Attachment 355104: Patch

https://bugs.webkit.org/attachment.cgi?id=355104&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 355104
  --> https://bugs.webkit.org/attachment.cgi?id=355104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355104&action=review

rs=me

Should we do anything special if the folder is already expanded? It seems like
in that case we’d effectively be doing nothing. I suppose I’d that’s what the
system does then it’s better to match 🤔

> Source/WebInspectorUI/ChangeLog:10
> +	   Match system behavior.

This comment isn’t descriptive. Either remove it or make it more explanatory.