[webkit-reviews] review granted: [Bug 191754] Add DidFirstMeaningfulPaint milestone. : [Attachment 355096] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 16 12:59:15 PST 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 191754: Add DidFirstMeaningfulPaint milestone.
https://bugs.webkit.org/show_bug.cgi?id=191754

Attachment 355096: Patch

https://bugs.webkit.org/attachment.cgi?id=355096&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 355096
  --> https://bugs.webkit.org/attachment.cgi?id=355096
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355096&action=review

>> Source/WebCore/ChangeLog:8
>> +	    This milestone fires soone after the paint, triggered by the
visually non-empty layout is finished.
> 
> soone => soon

"triggered by the visually non-empty layout is finished" doesn't parse.

"triggered by the first visually non-empty layout"?


More information about the webkit-reviews mailing list