[webkit-reviews] review denied: [Bug 191578] [GStreamer][MSE][Debug] Several debug tests are crashing after r238084 : [Attachment 355044] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 16 09:17:45 PST 2018


Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 191578: [GStreamer][MSE][Debug] Several debug tests are crashing after
r238084
https://bugs.webkit.org/show_bug.cgi?id=191578

Attachment 355044: Patch

https://bugs.webkit.org/attachment.cgi?id=355044&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 355044
  --> https://bugs.webkit.org/attachment.cgi?id=355044
Patch

We are assuming that isMainThread() => !caps, which I think is dangerous. We
should at least ASSERT on that


More information about the webkit-reviews mailing list