[webkit-reviews] review granted: [Bug 191722] [Mac] Regression: WebContent process's display name is no longer set : [Attachment 355062] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 16 09:11:02 PST 2018
Per Arne Vollan <pvollan at apple.com> has granted review:
Bug 191722: [Mac] Regression: WebContent process's display name is no longer
set
https://bugs.webkit.org/show_bug.cgi?id=191722
Attachment 355062: Patch
https://bugs.webkit.org/attachment.cgi?id=355062&action=review
--- Comment #12 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 355062
--> https://bugs.webkit.org/attachment.cgi?id=355062
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=355062&action=review
R=me.
> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:228
> + // Note that it is important for [NSApplication sharedApplication]
to have been called before setting the display name.
Replace [NSApplication sharedApplication] with _RegisterApplication.
> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:355
> + _RegisterApplication(NULL, NULL);
NULL -> nullptr
More information about the webkit-reviews
mailing list