[webkit-reviews] review granted: [Bug 191626] REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h : [Attachment 354901] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 15 23:51:14 PST 2018
Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 191626: REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is
using JSC::Structure::create without including StructureInlines.h
https://bugs.webkit.org/show_bug.cgi?id=191626
Attachment 354901: Patch
https://bugs.webkit.org/attachment.cgi?id=354901&action=review
--- Comment #6 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 354901
--> https://bugs.webkit.org/attachment.cgi?id=354901
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=354901&action=review
r=me
> Source/JavaScriptCore/runtime/Structure.h:135
> + inline static Structure* create(VM&, JSGlobalObject*, JSValue prototype,
const TypeInfo&, const ClassInfo*, IndexingType = NonArray, unsigned
inlineCapacity = 0);
I think this is `inline` is not necessary.
More information about the webkit-reviews
mailing list