[webkit-reviews] review granted: [Bug 191699] [GStreamer][WebRTC] Add API to enable/disable device mocks : [Attachment 354973] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 191699: [GStreamer][WebRTC] Add API to enable/disable device mocks
https://bugs.webkit.org/show_bug.cgi?id=191699

Attachment 354973: Patch

https://bugs.webkit.org/attachment.cgi?id=354973&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 354973
  --> https://bugs.webkit.org/attachment.cgi?id=354973
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354973&action=review

> Source/WebCore/ChangeLog:15
> +	       stream is similare to what Apple port does.

similar

> Source/WebKit/ChangeLog:15
> +	       stream is similare to what Apple port does.

similar

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:-163
> -    if (newSink == m_sink.get()) {
> -	   GST_INFO_OBJECT(m_pipeline.get(), "Setting queue as leaky upstream"
> -	       " so that the player can set the sink to PAUSED without "
> -	       " setting the whole capturer to PAUSED");
> -	   g_object_set(queue, "leaky", 2 /* upstream */, nullptr);
> -    }

If you remove this piece of code, you also want to remove one of the spaces,
either below os above to avoid having a double empty line.