[webkit-reviews] review granted: [Bug 191724] ASSERTION FAILED: m_lastOpcodeID == op_end || (m_lastOpcodeID == m_lastInstruction->opcodeID() && m_writer.position() == m_lastInstruction.offset() + m_lastInstruction->size()) : [Attachment 354995] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 191724: ASSERTION FAILED: m_lastOpcodeID == op_end || (m_lastOpcodeID ==
m_lastInstruction->opcodeID() && m_writer.position() ==
m_lastInstruction.offset() + m_lastInstruction->size())
https://bugs.webkit.org/show_bug.cgi?id=191724

Attachment 354995: Patch

https://bugs.webkit.org/attachment.cgi?id=354995&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 354995
  --> https://bugs.webkit.org/attachment.cgi?id=354995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354995&action=review

r=me

>>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4866
>>>	 }
>> 
>> Why isn't this unconditional?
> 
> Because if we're writing at end of the stream the lastInstruction we saved
might no longer be up-to-date. (i.e. it was op_get_direct_pname, but it was
replaced by op_get_by_val + op_nop, so the current value, which should be
op_nop, is correct.)

makes sense