[webkit-reviews] review requested: [Bug 191713] [CMake][AppleWin] Use DEBUG_SUFFIX only where needed : [Attachment 354987] WIP Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has asked	for review:
Bug 191713: [CMake][AppleWin] Use DEBUG_SUFFIX only where needed
https://bugs.webkit.org/show_bug.cgi?id=191713

Attachment 354987: WIP Patch

https://bugs.webkit.org/attachment.cgi?id=354987&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 354987
  --> https://bugs.webkit.org/attachment.cgi?id=354987
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354987&action=review

Made some comments so the changes make sense. ${DEBUG_SUFFIX} is just removed
from anything that will end up in a linked library.

Just turning on the review flag to see what might be required next.

> Source/ThirdParty/ANGLE/PlatformWin.cmake:38
> +if (DEBUG_SUFFIX)
> +    list(APPEND ANGLEGLESv2_LIBRARIES dxguid)
> +endif ()

If there's no DEBUG_SUFFIX _DEBUG is removed from the compiler flags. Compiling
with DEBUG_SUFFIX revealed that dxguid is needed when compiling ANGLE due to
missing symbols that are used when _DEBUG is present. This is why I suspect
that the build might not actually be working.

> Source/WebKitLegacy/PlatformWin.cmake:450
> -    PRIVATE WebKitGUID${DEBUG_SUFFIX}
> +    PRIVATE WebKitLegacyGUID

The original code might actually be a bug. I know we've had issues with IDL not
regenerating without a clean build.

> Source/WebKitLegacy/PlatformWin.cmake:458
> +	   libANGLE
> +	   libEGL
> +	   libGLESv2

ANGLE stuff does not actually contain a suffix. Its including a .exp file which
doesn't match the library name if I set things.