[webkit-reviews] review granted: [Bug 191701] [Win] Reduce the use of WKSI library calls: Font Handling : [Attachment 354976] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 191701: [Win] Reduce the use of WKSI library calls: Font Handling
https://bugs.webkit.org/show_bug.cgi?id=191701

Attachment 354976: Patch

https://bugs.webkit.org/attachment.cgi?id=354976&action=review




--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 354976
  --> https://bugs.webkit.org/attachment.cgi?id=354976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354976&action=review

r=me assuming the big green block is just copied/pasted from WKSI

> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:1141
> +	   flush();

This seems unrelated...

> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:1164
> +    flush();

Ditto.

> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:1194
> +    flush();

Ditto.

> Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp:151
> -    wkGetGlyphAdvances(font, m, m_platformData.isSystemFont(),
isPrinterFont, glyph, advance);
> +    FontCascade::getGlyphAdvances(font, m, m_platformData.isSystemFont(),
isPrinterFont, glyph, advance);

We have similarly named functions; I'd prefer putting the word "platform"
inside the name of this function somewhere.