[webkit-reviews] review granted: [Bug 191663] [WebGPU] WebGPUCommandBuffer prototype : [Attachment 354970] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 15 12:38:38 PST 2018
Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 191663: [WebGPU] WebGPUCommandBuffer prototype
https://bugs.webkit.org/show_bug.cgi?id=191663
Attachment 354970: Patch
https://bugs.webkit.org/attachment.cgi?id=354970&action=review
--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354970
--> https://bugs.webkit.org/attachment.cgi?id=354970
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=354970&action=review
> Source/WebCore/Modules/webgpu/cocoa/GPUQueueMetal.mm:50
> + queue = adoptNS([device.platformDevice() newCommandQueue]);
Why did you use retainPtr in the other file and adoptNS here?
More information about the webkit-reviews
mailing list