[webkit-reviews] review granted: [Bug 191631] [GStreamer][WebRTC] Add support for sending silence or silencing an incoming track : [Attachment 354918] Patch for landing

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted  review:
Bug 191631: [GStreamer][WebRTC] Add support for sending silence or silencing an
incoming track
https://bugs.webkit.org/show_bug.cgi?id=191631

Attachment 354918: Patch for landing

https://bugs.webkit.org/attachment.cgi?id=354918&action=review




--- Comment #9 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 354918
  --> https://bugs.webkit.org/attachment.cgi?id=354918
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=354918&action=review

> Source/WebCore/ChangeLog:20
> -	   Reviewed by NOBODY (OOPS!).
> +	   Reviewed by Xabier Rodriguez-Calvar.

Big ooops!

>
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWeb
RTC.cpp:123
> +    GstMappedBuffer outMap(outBuffer.get(), GST_MAP_WRITE);

I would say inMappedBuffer and out