[webkit-reviews] review granted: [Bug 188697] [css-logical] Flow relative margin, padding and border shorthands : [Attachment 353540] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 14 22:47:44 PST 2018
Antti Koivisto <koivisto at iki.fi> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 188697: [css-logical] Flow relative margin, padding and border shorthands
https://bugs.webkit.org/show_bug.cgi?id=188697
Attachment 353540: Patch
https://bugs.webkit.org/attachment.cgi?id=353540&action=review
--- Comment #98 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 353540
--> https://bugs.webkit.org/attachment.cgi?id=353540
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=353540&action=review
r=me, looks good
> Source/WebCore/css/CSSStyleDeclaration.cpp:244
> + CSSPropertyID id = static_cast<CSSPropertyID>(propertyID);
Could be auto
> Source/WebCore/css/StyleProperties.cpp:390
> + return String();
return { };
(some other places too)
> Source/WebCore/css/StyleProperties.cpp:393
> + PropertyReference start = propertyAt(startValueIndex);
> + PropertyReference end = propertyAt(endValueIndex);
auto
> Source/WebCore/css/parser/CSSPropertyParser.cpp:150
> + CSSPropertyID propertyID =
static_cast<CSSPropertyID>(hashTableEntry->id);
auto
More information about the webkit-reviews
mailing list