[webkit-reviews] review granted: [Bug 191662] [CMake][WTF] Mirror XCode header directories : [Attachment 354861] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 14 17:27:41 PST 2018
Michael Catanzaro <mcatanzaro at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 191662: [CMake][WTF] Mirror XCode header directories
https://bugs.webkit.org/show_bug.cgi?id=191662
Attachment 354861: Patch
https://bugs.webkit.org/attachment.cgi?id=354861&action=review
--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 354861
--> https://bugs.webkit.org/attachment.cgi?id=354861
Patch
LGTM.
This is a big change to how forwarding headers work, and I've never seen a
CMake patch get worse after review by Konstantin. CC Konstantin.
More information about the webkit-reviews
mailing list