[webkit-reviews] review granted: [Bug 191383] [WebGPU] Code quality concerns raised for 191291: [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain : [Attachment 354839] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 191383: [WebGPU] Code quality concerns raised for 191291: [WebGPU]
Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
https://bugs.webkit.org/show_bug.cgi?id=191383

Attachment 354839: Patch

https://bugs.webkit.org/attachment.cgi?id=354839&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354839
  --> https://bugs.webkit.org/attachment.cgi?id=354839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354839&action=review

> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:70
> +    const char* const functionName = "WebGPUDevice::createRenderPipeline()";
> +#if LOG_DISABLED
> +    UNUSED_PARAM(functionName);
> +#endif

I think it's ok to duplicate the function name in each LOG statement.

> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:82
> +	       LOG(WebGPU, "%s: Invalid WebGPUPipelineStageDescriptor!",
functionName);

Do we need the !!!!s ? :)