[webkit-reviews] review granted: [Bug 191494] Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector) : [Attachment 354690] [PATCH] Follow-up for Local Inspector

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted  review:
Bug 191494: Web Inspector: Keep Web Inspector window alive across process swaps
(PSON) (Remote Inspector)
https://bugs.webkit.org/show_bug.cgi?id=191494

Attachment 354690: [PATCH] Follow-up for Local Inspector

https://bugs.webkit.org/attachment.cgi?id=354690&action=review




--- Comment #15 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 354690
  --> https://bugs.webkit.org/attachment.cgi?id=354690
[PATCH] Follow-up for Local Inspector

View in context: https://bugs.webkit.org/attachment.cgi?id=354690&action=review

r=me

> Source/WebKit/ChangeLog:3
> +	   Web Inspector: Keep Web Inspector window alive across process swaps
(PSON) (Remote Inspector)

Do you want to make a new bug for this, or just have it as part of the same
one?

> Source/WebKit/WebProcess/WebPage/WebInspector.cpp:105
> +    m_page->setHasLocalInspectorFrontend(true);

NIT: I'd move this before the message send, as you'd want to set the state
before notifying listeners that the state has changed