[webkit-reviews] review granted: [Bug 191604] Add SPI to show a safe browsing warning : [Attachment 354721] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 14 10:25:37 PST 2018
Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 191604: Add SPI to show a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=191604
Attachment 354721: Patch
https://bugs.webkit.org/attachment.cgi?id=354721&action=review
--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 354721
--> https://bugs.webkit.org/attachment.cgi?id=354721
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=354721&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1285
> -- (void)_showSafeBrowsingWarning:(const WebKit::SafeBrowsingResult&)result
completionHandler:(CompletionHandler<void(Variant<WebKit::ContinueUnsafeLoad,
WebCore::URL>&&)>&&)completionHandler
> +- (void)_showSafeBrowsingWarningWithTitle:(NSString *)title
warning:(NSString *)warning details:(NSAttributedString *)details
completionHandler:(void(^)(BOOL, NSURL *))completionHandler
> {
> - _safeBrowsingWarning = adoptNS([[WKSafeBrowsingWarning alloc]
initWithFrame:self.bounds safeBrowsingResult:result completionHandler:[weakSelf
= WeakObjCPtr<WKWebView>(self), completionHandler = WTFMove(completionHandler)]
(auto&& result) mutable {
> +
> +}
Oops?
More information about the webkit-reviews
mailing list