[webkit-reviews] review granted: [Bug 191616] WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON : [Attachment 354764] Fixes the test

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 191616: WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling
PSON
https://bugs.webkit.org/show_bug.cgi?id=191616

Attachment 354764: Fixes the test

https://bugs.webkit.org/attachment.cgi?id=354764&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 354764
  --> https://bugs.webkit.org/attachment.cgi?id=354764
Fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=354764&action=review

r=me with simplification.

> Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp:126
> +    WKGeolocationManagerSetProvider(WKContextGetGeolocationManager(context),
&providerCallback.base);

Presumably, we can simply call:
WKGeolocationManagerSetProvider(WKContextGetGeolocationManager(context),
nullptr);

Looking at the implementation, I believe it would do the right thing.