[webkit-reviews] review granted: [Bug 191611] [WebRTC] Provide default implementation of LibWebRTCProvider : [Attachment 354740] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 191611: [WebRTC] Provide default implementation of LibWebRTCProvider
https://bugs.webkit.org/show_bug.cgi?id=191611

Attachment 354740: Patch

https://bugs.webkit.org/attachment.cgi?id=354740&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 354740
  --> https://bugs.webkit.org/attachment.cgi?id=354740
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354740&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:55
> -#if !PLATFORM(COCOA) && !PLATFORM(GTK) && !PLATFORM(WPE)
> +#if !USE(LIBWEBRTC) || (!PLATFORM(COCOA) && !USE(GSTREAMER))

Confusing... why not just:

#if !USE(LIBWEBRTC)

>> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:71
>> +#endif
> 
> I know this was in the original code for cocoa returning true but I have a
feeling this is a bug on their end. If so you can just collapse this into one
big #if

Yeah Don is right, there's no way this is supposed to return true. We could do
archaeology to figure out where it broke... or just fix it now. :)