[webkit-reviews] review granted: [Bug 191591] Add support for RTCRtpCodecParameters.sdpFmtpLine : [Attachment 354680] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 191591: Add support for RTCRtpCodecParameters.sdpFmtpLine
https://bugs.webkit.org/show_bug.cgi?id=191591

Attachment 354680: Patch

https://bugs.webkit.org/attachment.cgi?id=354680&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 354680
  --> https://bugs.webkit.org/attachment.cgi?id=354680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354680&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:144
> +	   sdpFmtpLineBuilder.appendLiteral("=");

Nit: I have always heard that sdpFmtpLineBuilder.appendLiteral.append('=') is
more efficient