[webkit-reviews] review granted: [Bug 191600] TypeProfileLog::processLogEntries should stash away any pending exceptions and re-apply them to the VM : [Attachment 354706] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 15:14:28 PST 2018


Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 191600: TypeProfileLog::processLogEntries should stash away any pending
exceptions and re-apply them to the VM
https://bugs.webkit.org/show_bug.cgi?id=191600

Attachment 354706: patch

https://bugs.webkit.org/attachment.cgi?id=354706&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 354706
  --> https://bugs.webkit.org/attachment.cgi?id=354706
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354706&action=review

r=me with fixes.

> Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:63
> +    // thrown, so we don't calcualtedDisplayName to clear that exception
that

/don't/don't want/

> Source/JavaScriptCore/runtime/VM.h:901
> +	       : m_savedException(vm.m_exception)
> +	       , m_savedLastException(vm.m_lastException)

This should be:
	    : m_savedException(vm.m_exception, nullptr)
	    , m_savedLastException(vm.m_lastException, nullptr)

Otherwise, you would not be "deferring" the exception.


More information about the webkit-reviews mailing list