[webkit-reviews] review granted: [Bug 191596] [iOS] Shift + Tab does not focus previous field : [Attachment 354699] Patch and layout tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 191596: [iOS] Shift + Tab does not focus previous field
https://bugs.webkit.org/show_bug.cgi?id=191596

Attachment 354699: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=354699&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 354699
  --> https://bugs.webkit.org/attachment.cgi?id=354699
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=354699&action=review

r=me, with non-internal iOS builds fixed

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2427
> +	   return [self isFirstResponder];

Have you considered consulting `AssistedNodeInformation.hasNextNode` or
`AssistedNodeInformation.hasPreviousNode` as well?