[webkit-reviews] review granted: [Bug 191442] [iOS] Do not show selection UI for editable elements with opacity near zero : [Attachment 354650] Add missing layout test.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 191442: [iOS] Do not show selection UI for editable elements with opacity
near zero
https://bugs.webkit.org/show_bug.cgi?id=191442

Attachment 354650: Add missing layout test.

https://bugs.webkit.org/attachment.cgi?id=354650&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 354650
  --> https://bugs.webkit.org/attachment.cgi?id=354650
Add missing layout test.

View in context: https://bugs.webkit.org/attachment.cgi?id=354650&action=review

> Source/WebCore/rendering/RenderObject.cpp:1525
> +	   if (layerRenderer.style().opacity() < minimumVisibleOpacity)
> +	       return true;

Opacity is multiplicative, so ideally you'd multiply it during your tree walk.
For example, try ten nested divs with opacity 0.1.