[webkit-reviews] review granted: [Bug 190100] Web Inspector: Table with no selection should select the first/last row on down/up arrow key : [Attachment 354672] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 190100: Web Inspector: Table with no selection should select the first/last
row on down/up arrow key
https://bugs.webkit.org/show_bug.cgi?id=190100

Attachment 354672: Patch

https://bugs.webkit.org/attachment.cgi?id=354672&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 354672
  --> https://bugs.webkit.org/attachment.cgi?id=354672
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354672&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Table.js:454
> +	   this.needsLayout();

If we wait for a layout rAF, we'll end up flashing content as we will scroll
before the new content is visible.  I think this should be `updateLayout` if
the row isn't currently visible, but it can stay as is for rows that are.

> Source/WebInspectorUI/UserInterface/Views/Table.js:1304
> +	   if (event.metaKey || event.ctrlKey)
>	       return;

Duplicate of next line.  Please remove.