[webkit-reviews] review granted: [Bug 191435] Web Inspector: Styles: Command-A should select all properties : [Attachment 354612] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 13 09:32:47 PST 2018
Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 191435: Web Inspector: Styles: Command-A should select all properties
https://bugs.webkit.org/show_bug.cgi?id=191435
Attachment 354612: Patch
https://bugs.webkit.org/attachment.cgi?id=354612&action=review
--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 354612
--> https://bugs.webkit.org/attachment.cgi?id=354612
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=354612&action=review
r=me, nice refactoring :)
>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.
js:559
> + if (!this._hasSelectedProperties() || this._propertyViews.length
=== 0)
Style: `!this._propertyViews.length`
More information about the webkit-reviews
mailing list