[webkit-reviews] review denied: [Bug 158342] Overlay with -webkit-overflow-scrolling:touch doesn't become scrollable after added text makes it taller : [Attachment 354616] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 158342: Overlay with -webkit-overflow-scrolling:touch doesn't become
scrollable after added text makes it taller
https://bugs.webkit.org/show_bug.cgi?id=158342

Attachment 354616: Patch

https://bugs.webkit.org/attachment.cgi?id=354616&action=review




--- Comment #29 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 354616
  --> https://bugs.webkit.org/attachment.cgi?id=354616
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354616&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:3579
>> +#endif
> 
> This version fixes repro cases from comment 0, comment 4, attachment 353483
[details] but the issue remains for attachment 353703 [details].

Compared to attachment 353880, this is lacking the call to
RenderLayerBacking::updateConfiguration() in order to instantiate the
m_scrollingLayer. Not sure why it was enough for most of the repro cases, but
for attachment 353703 it seems we really need to call
setNeedsCompositingConfigurationUpdate() if we really want
RenderLayerCompositor::updateBackingAndHierarchy to do the necessary work.

>> LayoutTests/fast/scrolling/ios/become-scrollable-on-content-resize.html:56
>> +	  </div>
> 
> OK, maybe I should have tried harder to integrate the repro case from
attachment 353703 [details], sorry about that :-/

We need to convert this repro case into a regression test.