[webkit-reviews] review granted: [Bug 191406] [Curl] Reject entire cookie if the domain fails a tailmatch. : [Attachment 354600] PATCH

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 191406: [Curl] Reject entire cookie if the domain fails a tailmatch.
https://bugs.webkit.org/show_bug.cgi?id=191406

Attachment 354600: PATCH

https://bugs.webkit.org/attachment.cgi?id=354600&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 354600
  --> https://bugs.webkit.org/attachment.cgi?id=354600
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=354600&action=review

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:478
> +	   || !CookieUtil::domainMatch(cookie->domain, host))

maybe rewrite it as 
if (fromJavaScript && (cookie->httpOnly || hasHttpOnlyCookie(cookie->name,
cookie->domain, cookie->path))
    return false;
if (!CookieUtil::domainMatch(cookie->domain, host))
    return false;