[webkit-reviews] review granted: [Bug 191493] [Curl] Add API Test for Curl cookie backend. : [Attachment 354582] Fix

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 191493: [Curl] Add API Test for Curl cookie backend.
https://bugs.webkit.org/show_bug.cgi?id=191493

Attachment 354582: Fix

https://bugs.webkit.org/attachment.cgi?id=354582&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 354582
  --> https://bugs.webkit.org/attachment.cgi?id=354582
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=354582&action=review

> Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp:51
> +	   for (auto cookie : *result) {

s/auto/auto&

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:434
> +    SQLiteStatement* statement = getPrepareStatement(SET_COOKIE_SQL);

s/SQLiteStatement/auto/
Also maybe getPrepareStatement should return a SQLiteStatement&

> Source/WebCore/platform/network/curl/CookieJarDB.h:43
> +    enum class Source : uint8_t {

Do we need " : uint8_t"?

> Source/WebCore/platform/network/curl/CookieUtil.cpp:147
> +	   return std::nullopt;

You can also write it { }, which is shorter.
Not exactly sure what is the recommended way.