[webkit-reviews] review granted: [Bug 191332] Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits. : [Attachment 354016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 10:21:30 PST 2018


Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 191332: Add a git utility method that allows the caller to determine if a
specific commitish is within a specified range of commits.
https://bugs.webkit.org/show_bug.cgi?id=191332

Attachment 354016: Patch

https://bugs.webkit.org/attachment.cgi?id=354016&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354016
  --> https://bugs.webkit.org/attachment.cgi?id=354016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354016&action=review

> Tools/Scripts/git-is-in-range:3
> +USAGE="<commit range> <commit> [commit...]"

Another request was given a set of ranges, find the overlapping range.

Maybe you should explain what a <commit range> looks like? I assume it is
hash1..hash2?


More information about the webkit-reviews mailing list