[webkit-reviews] review granted: [Bug 191382] SVG2: Add bounding-box keyword to pointer-events : [Attachment 354108] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 191382: SVG2: Add bounding-box keyword to pointer-events
https://bugs.webkit.org/show_bug.cgi?id=191382

Attachment 354108: Patch

https://bugs.webkit.org/attachment.cgi?id=354108&action=review




--- Comment #12 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354108
  --> https://bugs.webkit.org/attachment.cgi?id=354108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354108&action=review

> Source/WebCore/css/CSSValueKeywords.in:994
> +bounding-box

I wonder why CSSValueKeywords.in isn't generated from CSSProperties.json?

> LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.txt:664
> +	     chunk 1 text run 1 at (390.00,640.00) startOffset 0 endOffset 4
width 29.34: "miss"
> +	 RenderSVGRect {rect} at (0,0) size 0x0 [fill={[type=SOLID]
[color=#FFA500]}] [x=442.00] [y=600.00] [width=50.00] [height=50.00]
> +	 RenderSVGText {text} at (447,606) size 30x18 contains 1 chunk(s)

Yikes. Why are all these non-text dumps?