[webkit-reviews] review granted: [Bug 181640] Support dynamic pseudo-classes on elements with display: contents : [Attachment 354330] rebased patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 181640: Support dynamic pseudo-classes on elements with display: contents
https://bugs.webkit.org/show_bug.cgi?id=181640

Attachment 354330: rebased patch

https://bugs.webkit.org/attachment.cgi?id=354330&action=review




--- Comment #12 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354330
  --> https://bugs.webkit.org/attachment.cgi?id=354330
rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354330&action=review

> Source/WebCore/dom/Element.cpp:2920
> +    if (!hasRareData())
> +	   return nullptr;
> +    auto* style = elementRareData()->computedStyle();
> +    if (style && style->display() == DisplayType::Contents)

Could you have

if (!hasRareData() || !hasDisplayContents())
  return nullptr;

return elementRareData()->computedStyle();

Either way is fine with me.