[webkit-reviews] review granted: [Bug 191549] Content extensions: Add noop action type : [Attachment 354563] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 09:59:23 PST 2018


Dean Jackson <dino at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 191549: Content extensions: Add noop action type
https://bugs.webkit.org/show_bug.cgi?id=191549

Attachment 354563: Patch

https://bugs.webkit.org/attachment.cgi?id=354563&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354563
  --> https://bugs.webkit.org/attachment.cgi?id=354563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354563&action=review

> Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:66
>      case ActionType::MakeHTTPS:
>	   return os << "ActionType::MakeHTTPS";
> +    case ActionType::Noop:
> +	   return os << "ActionType::MakeHTTPS";

Can be merged.


More information about the webkit-reviews mailing list