[webkit-reviews] review granted: [Bug 191490] RealtimeOutgoing A/V sources should observe their sources only if having a sink : [Attachment 354438] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 191490: RealtimeOutgoing A/V sources should observe their sources only if
having a sink
https://bugs.webkit.org/show_bug.cgi?id=191490

Attachment 354438: Patch

https://bugs.webkit.org/attachment.cgi?id=354438&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 354438
  --> https://bugs.webkit.org/attachment.cgi?id=354438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354438&action=review

> Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.cpp:65
> +    observeSource();

As we discussed, this shouldn't be necessary because you also call it in
AddSink.

> Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:73
> +    observeSource();

Ditto.

> Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:81
>      m_videoSource->removeObserver(*this);

Nit: why does RealtimeOutgoingAudioSource have unobserveSource and
RealtimeOutgoingVideoSource just calls removeObserver?