[webkit-reviews] review granted: [Bug 191542] [Web Animations] Don't schedule animation frames or update style while an accelerated animation is running : [Attachment 354546] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 191542: [Web Animations] Don't schedule animation frames or update style
while an accelerated animation is running
https://bugs.webkit.org/show_bug.cgi?id=191542

Attachment 354546: Patch

https://bugs.webkit.org/attachment.cgi?id=354546&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 354546
  --> https://bugs.webkit.org/attachment.cgi?id=354546
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354546&action=review

> Source/WebCore/animation/DocumentTimeline.cpp:316
> +    m_waitingOnVMIdle = true;
> +    if (!m_currentTimeClearingTaskQueue.hasPendingTasks())
> +	  
m_currentTimeClearingTaskQueue.enqueueTask(std::bind(&DocumentTimeline::maybeCl
earCachedCurrentTime, this));
> +    m_document->vm().whenIdle([this, protectedThis = makeRefPtr(this)]() {
> +	   m_waitingOnVMIdle = false;
> +	   maybeClearCachedCurrentTime();
> +    });

Is the VM going idle correct in terms of HTMLEventLoop behaviors, or is this a
stop-gap until we have that?