[webkit-reviews] review granted: [Bug 191457] commit time returned by '/api/measurement-set' should match the one returned by '/api/commits'. : [Attachment 354454] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 191457: commit time returned by '/api/measurement-set' should match the one
returned by '/api/commits'.
https://bugs.webkit.org/show_bug.cgi?id=191457

Attachment 354454: Patch

https://bugs.webkit.org/attachment.cgi?id=354454&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 354454
  --> https://bugs.webkit.org/attachment.cgi?id=354454
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354454&action=review

> Websites/perf.webkit.org/public/include/db.php:105
>	   if ($dot_index !== FALSE)

Per WebKit's styling guideline, you'd need { ~ } around the comment & the
statement.
Even when there is a single statement, when there is an additional line used
for a comment, you'd need { ~ }.

> Websites/perf.webkit.org/public/include/db.php:108
> +	       $timestamp_in_ms += round(floatval(substr($time_str,
$dot_index)), 5) * 1000;

Did you verify that postgres rounds up 5?
Not even/odd or a round-down? See http://php.net/manual/en/function.round.php
for options.