[webkit-reviews] review granted: [Bug 191480] Add ability to configure document.cookie lifetime cap through user defaults : [Attachment 354415] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 191480: Add ability to configure document.cookie lifetime cap through user
defaults
https://bugs.webkit.org/show_bug.cgi?id=191480

Attachment 354415: Patch

https://bugs.webkit.org/attachment.cgi?id=354415&action=review




--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 354415
  --> https://bugs.webkit.org/attachment.cgi?id=354415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354415&action=review

r=me with comment.

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h:143
> +    WebsiteDataStore* getWebsiteDataStore() { return
m_websiteDataStore.get(); }

We NEVER use 'get' prefix for getters in WebKit. This should be named
websiteDataStore().