[webkit-reviews] review granted: [Bug 191485] [MSE] Frame re-ordering can cause iframes to never be enqueued : [Attachment 354378] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 13:31:49 PST 2018


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 191485: [MSE] Frame re-ordering can cause iframes to never be enqueued
https://bugs.webkit.org/show_bug.cgi?id=191485

Attachment 354378: Patch

https://bugs.webkit.org/attachment.cgi?id=354378&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 354378
  --> https://bugs.webkit.org/attachment.cgi?id=354378
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354378&action=review

> Source/WebCore/ChangeLog:13
> +	   DTS overlaps an existing sample, but the the presentation timestamp
does not.

Nit: s/the the/the/

> LayoutTests/media/media-source/media-source-dropped-iframe.html:4
> +    <title>mock-media-source</title>

Nit: this isn't terribly descriptive


More information about the webkit-reviews mailing list