[webkit-reviews] review requested: [Bug 191435] Web Inspector: Styles: Command-A should select all properties : [Attachment 354358] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 191435: Web Inspector: Styles: Command-A should select all properties
https://bugs.webkit.org/show_bug.cgi?id=191435

Attachment 354358: Patch

https://bugs.webkit.org/attachment.cgi?id=354358&action=review




--- Comment #6 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 354358

  --> https://bugs.webkit.org/attachment.cgi?id=354358&action=review

Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354271&action=review

>>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.
js:553
>> +		if (!this._hasSelectedProperties() ||
this._propertyViews.length === 0)
> 
> This makes me think that we would only respond to this event if something is
selected.  That doesn't make a lot of sense.  I think what we want to do is
bail if any property is currently being edited.

I think it's fine as it is. Currently, I only want Command-A to work when at
least one property is selected. Property can't be selected when I edit a name
or value.

I want to refactor `editing` getter because it isn't longer accurate but I
don't want to do it in this patch.