[webkit-reviews] review granted: [Bug 190565] [iOS] Draw caps lock indicator in password fields : [Attachment 354290] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 190565: [iOS] Draw caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=190565

Attachment 354290: Patch

https://bugs.webkit.org/attachment.cgi?id=354290&action=review




--- Comment #11 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354290
  --> https://bugs.webkit.org/attachment.cgi?id=354290
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354290&action=review

> Source/WebCore/platform/cocoa/KeyEventCocoa.mm:33
> +#import <wtf/MainThread.h>

Why did you need this?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3761
> +    bool isHardwareKeyboardEvent = !!event._hidEvent;
> +    if (isHardwareKeyboardEvent && ((UIPhysicalKeyboardEvent
*)event)._inputFlags & kUIKeyboardInputModifierFlagsChanged)
> +	   _page->updateCurrentModifierState();

Why do we only want this with the hardware keyboard? I feel like we should also
do it if you've activated capslock on the software keyboard.