[webkit-reviews] review granted: [Bug 191443] CSS Painting API should pass 'this' correctly to paint callback, and repaint when properties change. : [Attachment 354306] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 191443: CSS Painting API should pass 'this' correctly to paint callback,
and repaint when properties change.
https://bugs.webkit.org/show_bug.cgi?id=191443

Attachment 354306: Patch

https://bugs.webkit.org/attachment.cgi?id=354306&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354306
  --> https://bugs.webkit.org/attachment.cgi?id=354306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354306&action=review

> Source/WebCore/ChangeLog:9
> +	   Also, this patch makes sure that custon paint elements get repainted
when properties that they care about get changed.

Typo: custom

> Source/WebCore/bindings/js/JSDOMWrapper.cpp:38
>  namespace WebCore {
> +using namespace JSC;

We usually put a blank line between these.

> Source/WebCore/rendering/style/RenderStyle.h:1877
> +    std::unique_ptr<HashSet<String>> m_customPaintWatchProperties;

I wonder if you should "using" HashSet<String> to something like
CustomPaintNameSet

> Source/WebCore/worklets/PaintWorkletGlobalScope.cpp:56
> -    if (!responsableDocument() || !responsableDocument()->domWindow())
> +    if (!responsibleDocument() || !responsibleDocument()->domWindow())
>	   return 1.0;
> -    return responsableDocument()->domWindow()->devicePixelRatio();
> +    return responsibleDocument()->domWindow()->devicePixelRatio();

Very nice!