[webkit-reviews] review granted: [Bug 191449] Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView : [Attachment 354299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 09:00:11 PST 2018


Eric Carlson <eric.carlson at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 191449: Make use of _UIRemoteView instead of CALayerHost if possible for
WKRemoteView
https://bugs.webkit.org/show_bug.cgi?id=191449

Attachment 354299: Patch

https://bugs.webkit.org/attachment.cgi?id=354299&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 354299
  --> https://bugs.webkit.org/attachment.cgi?id=354299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354299&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:189
> +	   std::call_once(initializeCanUseUIRemoteView, [] {
> +	       canUseUIRemoteView = [_UIRemoteView
instancesRespondToSelector:@selector(initWithFrame:pid:contextID:)];
> +	   });

Nit: this indentation is odd, although the style-bot didn't complain and it is
usually much more picky than I am.


More information about the webkit-reviews mailing list