[webkit-reviews] review granted: [Bug 191445] [LFC][IFC] Move some code from InlineFormattingContext::Line to InlineFormattingContext/Geometry : [Attachment 354311] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 191445: [LFC][IFC] Move some code from InlineFormattingContext::Line to
InlineFormattingContext/Geometry
https://bugs.webkit.org/show_bug.cgi?id=191445

Attachment 354311: Patch

https://bugs.webkit.org/attachment.cgi?id=354311&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 354311
  --> https://bugs.webkit.org/attachment.cgi?id=354311
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354311&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:87
>	   InlineFormattingState& m_formattingState;

Maybe the InlineFormattingState can be passed to the functions that need it? It
seems bit silly to have this backpointer in every Line instance.

>
Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:111
> +    expansionBehavior ^= AllowTrailingExpansion;
> +    expansionBehavior |= ForbidTrailingExpansion;

Should modernize this to use OptionSet at some point.