[webkit-reviews] review denied: [Bug 191328] Web Inspector: Table should recalculate scrollable height when resized : [Attachment 354023] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 191328: Web Inspector: Table should recalculate scrollable height when
resized
https://bugs.webkit.org/show_bug.cgi?id=191328

Attachment 354023: Patch

https://bugs.webkit.org/attachment.cgi?id=354023&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 354023
  --> https://bugs.webkit.org/attachment.cgi?id=354023
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354023&action=review

r-, see comments below

> Source/WebInspectorUI/UserInterface/Views/Table.js:534
> +	   this._resizeColumnsAndFiller();

I think this will have a different effect than what was there before.  Calling
`resize` guaranteed that `_cachedWidth` was recalculated, whereas just calling
`_resizeColumnsAndFiller` doesn't.  Setting `_columnWidths` to `null` does
ensure that it is recalculated, but it doesn't affect `_cachedWidth`.

> Source/WebInspectorUI/UserInterface/Views/Table.js:844
> +	   if (this._columnWidths && this._cachedWidth ===
this._previousCachedWidth) {

You should update `_previousCachedWidth` after this so that the next time this
is called it will be equal.