[webkit-reviews] review granted: [Bug 191415] U+180E is no longer a whitespace character : [Attachment 354248] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 14:38:28 PST 2018


Saam Barati <sbarati at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 191415: U+180E is no longer a whitespace character
https://bugs.webkit.org/show_bug.cgi?id=191415

Attachment 354248: Patch

https://bugs.webkit.org/attachment.cgi?id=354248&action=review




--- Comment #19 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 354248
  --> https://bugs.webkit.org/attachment.cgi?id=354248
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354248&action=review

r=me

> Source/JavaScriptCore/parser/Lexer.h:241
>  ALWAYS_INLINE bool Lexer<UChar>::isWhiteSpace(UChar ch)

Can we combine this w/ isStrWhiteSpace somehow inside ParseInt.h?


More information about the webkit-reviews mailing list