[webkit-reviews] review granted: [Bug 190454] Add an SPI to allow WebView clients to add additional supported image formats : [Attachment 353054] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 190454: Add an SPI to allow WebView clients to add additional supported
image formats
https://bugs.webkit.org/show_bug.cgi?id=190454

Attachment 353054: Patch

https://bugs.webkit.org/attachment.cgi?id=353054&action=review




--- Comment #30 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 353054
  --> https://bugs.webkit.org/attachment.cgi?id=353054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353054&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:104
> + at property (nonatomic, copy, setter=_setSupportedAdditionalImageSourceTypes:)
NSArray<NSString *> *_supportedAdditionalImageSourceTypes
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

This name is cumbersome and doesn't make it clear that the arguments are UTIs.
Maybe better as _additionalSupportedImageTypes: with a comment saying that the
argument is an array of UTIs.