[webkit-reviews] review granted: [Bug 190825] [MediaStream] Use DeviceIdHashSaltStorage to generate device ID hash salt : [Attachment 354234] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 190825: [MediaStream] Use DeviceIdHashSaltStorage to generate device ID
hash salt
https://bugs.webkit.org/show_bug.cgi?id=190825

Attachment 354234: Patch

https://bugs.webkit.org/attachment.cgi?id=354234&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 354234
  --> https://bugs.webkit.org/attachment.cgi?id=354234
Patch

r=me.
It seems that there might be a follow-up which will be to delete the salt in
case some access is not granted anymore, right?
Are we missing anything for enabling persistent device ids after grant?
Should we add some tests doing grant gum/reload page/grant gum/check ids before
and after reload, or grant gum/reload page/try gum with device ids from initial
page load?



View in context: https://bugs.webkit.org/attachment.cgi?id=354234&action=review

> Source/WebKit/UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp:-96
> -    auto salt =
priv->deviceIdHashSaltStorage->regenerateDeviceIdHashSaltForOrigin(*priv->reque
st);

Do we need regenerateDeviceIdHashSaltForOrigin anymore?

> Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.cpp:47
>      if (!m_completionHandler)

I would add ASSERT(!m_completionHandler);
I would be tempted to remove the if statement, but this might be too much for
now.